linux-kernel - Re: [RFC-ish PATCH 00/17] Clean up ASPEED devicetree warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5a6a22f8-d459-4aec-b69b-e49d096afa85@www.fastmail.com>
Date:   Mon, 05 Aug 2019 10:18:21 +0930
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Joel Stanley" <joel@....id.au>
Cc:     "Rob Herring" <robh+dt@...nel.org>, linux-aspeed@...ts.ozlabs.org,
        "Mark Rutland" <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Adriana Kobylak" <anoo@...ibm.com>,
        "Alexander A. Filippov" <a.filippov@...ro.com>,
        "Arnd Bergmann" <arnd@...db.de>,
        YangBrianC.W 楊嘉偉 TAO 
        <yang.brianc.w@...entec.com>, "Corey Minyard" <minyard@....org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Haiyue Wang" <haiyue.wang@...ux.intel.com>,
        "John Wang" <wangzqbj@...pur.com>,
        "Ken Chen" <chen.kenyy@...entec.com>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        openipmi-developer@...ts.sourceforge.net,
        "Patrick Venture" <venture@...gle.com>,
        "Stefan M Schaeckeler" <sschaeck@...co.com>,
        "Tao Ren" <taoren@...com>, "Xo Wang" <xow@...gle.com>,
        yao.yuan@...aro.org
Subject: Re: [RFC-ish PATCH 00/17] Clean up ASPEED devicetree warnings



On Fri, 2 Aug 2019, at 15:21, Joel Stanley wrote:
> On Tue, 30 Jul 2019 at 01:09, Andrew Jeffery <andrew@...id.au> wrote:
> 
> > > > The bang-for-buck is in fixing up the KCS bindings which removes all-but-two of
> > > > the remaining warnings (which we can't feasibly remove), but doing so forces
> > > > code changes (which I'd avoided up until this point).
> > > >
> > > > Reflecting broadly on the fixes, I think I've made a mistake way back by using
> > > > syscon/simple-mfds to expose the innards of the SCU and LPC controllers in the
> > > > devicetree. This series cleans up what's currently there, but I have half a
> > > > mind to rev the SCU and LPC bindings to not use simple-mfd and instead have a
> > > > driver implementation that uses `platform_device_register_full()` or similar to
> > > > deal with the mess.
> > > >
> > > > Rob - I'm looking for your thoughts here and on the series, I've never felt
> > > > entirely comfortable with what I cooked up. Your advice would be appreciated.
> > >
> > > The series generally looks fine to me from a quick scan. As far as
> > > dropping 'simple-mfd', having less fine grained description in DT is
> > > generally my preference. It comes down to whether what you have
> > > defined is maintainable. As most of it is just additions, I think what
> > > you have is fine. Maybe keep all this in mind for the next chip
> > > depending how the SCU and LPC change.
> >
> > Okay, I think the timing of that suggestion is good given where things are with
> > the AST2600. I'll keep that in mind.
> >
> > Consensus so far seems to be that the series is fine. I'll split it up and send out
> > the sub-series to the relevant lists with the acks accumulated here.
> 
> The series look good. I suggest posting the KCS bindings and driver
> changes as their own series to go through the IPMI tree.

Yeah, that was the plan.

> 
> Please add my tag to all the patches except the OCC one, which I need
> to do some investigation in to.
> 
> Reviewed-by: Joel Stanley <joel@....id.au>

Thanks, will do.

> 
> The others can go via the aspeed tree. Perhaps post them as their own
> series too so I don't get confused and apply the wrong ones. That way
> if Rob wants to send his reviewed-by he can.

SGTM.

Cheers,

Andrew