linux-kernel - RE: [PATCH v5 2/4] mailbox: imx: Clear the right interrupts at shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4211D61BDF46688E5825DF0F80DA0@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date:   Mon, 5 Aug 2019 04:43:33 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Richard Zhu <hongxing.zhu@....com>,
        "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
        "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
        Daniel Baluta <daniel.baluta@....com>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Richard Zhu <hongxing.zhu@....com>
Subject: RE: [PATCH v5 2/4] mailbox: imx: Clear the right interrupts at
 shutdown

> From: Richard Zhu <hongxing.zhu@....com>
> Sent: Monday, August 5, 2019 10:51 AM
> 
> Make sure to only clear enabled interrupts keeping count of the connection
> type.
> 
> Suggested-by: Oleksij Rempel <o.rempel@...gutronix.de>
> Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> Signed-off-by: Richard Zhu <hongxing.zhu@....com>

Keep original author if any.
Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@....com>

Regards
Aisheng

> ---
>  drivers/mailbox/imx-mailbox.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
> index 1eeabc5..afe625e 100644
> --- a/drivers/mailbox/imx-mailbox.c
> +++ b/drivers/mailbox/imx-mailbox.c
> @@ -219,8 +219,19 @@ static void imx_mu_shutdown(struct mbox_chan
> *chan)
>  		return;
>  	}
> 
> -	imx_mu_xcr_rmw(priv, 0,
> -		   IMX_MU_xCR_TIEn(cp->idx) | IMX_MU_xCR_RIEn(cp->idx));
> +	switch (cp->type) {
> +	case IMX_MU_TYPE_TX:
> +		imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_TIEn(cp->idx));
> +		break;
> +	case IMX_MU_TYPE_RX:
> +		imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_RIEn(cp->idx));
> +		break;
> +	case IMX_MU_TYPE_RXDB:
> +		imx_mu_xcr_rmw(priv, 0, IMX_MU_xCR_GIEn(cp->idx));
> +		break;
> +	default:
> +		break;
> +	}
> 
>  	free_irq(priv->irq, chan);
>  }
> --
> 2.7.4