linux-kernel - RE: [PATCH v5 1/4] mailbox: imx: Fix Tx doorbell shutdown path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR0402MB357045BED7FE702C837F5CC88CDA0@AM0PR0402MB3570.eurprd04.prod.outlook.com>
Date:   Mon, 5 Aug 2019 05:10:30 +0000
From:   Richard Zhu <hongxing.zhu@....com>
To:     Aisheng Dong <aisheng.dong@....com>,
        "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
        "o.rempel@...gutronix.de" <o.rempel@...gutronix.de>,
        Daniel Baluta <daniel.baluta@....com>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v5 1/4] mailbox: imx: Fix Tx doorbell shutdown path


> -----Original Message-----
> From: Aisheng Dong
> Sent: 2019年8月5日 12:38
> To: Richard Zhu <hongxing.zhu@....com>; jassisinghbrar@...il.com;
> o.rempel@...gutronix.de; Daniel Baluta <daniel.baluta@....com>
> Cc: dl-linux-imx <linux-imx@....com>; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; Richard Zhu <hongxing.zhu@....com>
> Subject: RE: [PATCH v5 1/4] mailbox: imx: Fix Tx doorbell shutdown path
> 
> > From: Richard Zhu <hongxing.zhu@....com>
> > Sent: Monday, August 5, 2019 10:51 AM
> >
> > Tx doorbell is handled by txdb_tasklet and doesn't have an associated IRQ.
> >
> > Anyhow, imx_mu_shutdown ignores this and tries to free an IRQ that
> > wasn't requested for Tx DB resulting in the following warning:
> >
> > [    1.967644] Trying to free already-free IRQ 26
> > [    1.972108] WARNING: CPU: 2 PID: 157 at kernel/irq/manage.c:1708
> > __free_irq+0xc0/0x358
> > [    1.980024] Modules linked in:
> > [    1.983088] CPU: 2 PID: 157 Comm: kworker/2:1 Tainted: G
> > [    1.993524] Hardware name: Freescale i.MX8QXP MEK (DT)
> > [    1.998668] Workqueue: events deferred_probe_work_func
> > [    2.003812] pstate: 60000085 (nZCv daIf -PAN -UAO)
> > [    2.008607] pc : __free_irq+0xc0/0x358
> > [    2.012364] lr : __free_irq+0xc0/0x358
> > [    2.016111] sp : ffff00001179b7e0
> > [    2.019422] x29: ffff00001179b7e0 x28: 0000000000000018
> > [    2.024736] x27: ffff000011233000 x26: 0000000000000004
> > [    2.030053] x25: 000000000000001a x24: ffff80083bec74d4
> > [    2.035369] x23: 0000000000000000 x22: ffff80083bec7588
> > [    2.040686] x21: ffff80083b1fe8d8 x20: ffff80083bec7400
> > [    2.046003] x19: 0000000000000000 x18: ffffffffffffffff
> > [    2.051320] x17: 0000000000000000 x16: 0000000000000000
> > [    2.056637] x15: ffff0000111296c8 x14: ffff00009179b517
> > [    2.061953] x13: ffff00001179b525 x12: ffff000011142000
> > [    2.067270] x11: ffff000011129f20 x10: ffff0000105da970
> > [    2.072587] x9 : 00000000ffffffd0 x8 : 0000000000000194
> > [    2.077903] x7 : 612065657266206f x6 : ffff0000111e7b09
> > [    2.083220] x5 : 0000000000000003 x4 : 0000000000000000
> > [    2.088537] x3 : 0000000000000000 x2 : 00000000ffffffff
> > [    2.093854] x1 : 28b70f0a2b60a500 x0 : 0000000000000000
> > [    2.099173] Call trace:
> > [    2.101618]  __free_irq+0xc0/0x358
> > [    2.105021]  free_irq+0x38/0x98
> > [    2.108170]  imx_mu_shutdown+0x90/0xb0
> > [    2.111921]  mbox_free_channel.part.2+0x24/0xb8
> > [    2.116453]  mbox_free_channel+0x18/0x28
> >
> > This bug is present from the beginning of times.
> >
> > Cc: Oleksij Rempel <o.rempel@...gutronix.de>
> > Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> 
> I think you should keep the original author and Fixes tag.
> Otherwise:
> Reviewed-by: Dong Aisheng <aisheng.dong@....com>
> 
[Richard Zhu] Sorry about the author changes, because there are confliction
 when I use "git am" to merge this patch.
Would change the author back, and re-send the v5 patch-set.
> Regards
> Aisheng