linux-kernel - Re: linux-next: build warning after merge of the driver-core tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Aug 2019 17:03:18 -0700
From:   Saravana Kannan <saravanak@...gle.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Greg KH <greg@...ah.com>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the driver-core tree

On Sun, Aug 4, 2019 at 9:56 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> On Mon, 5 Aug 2019 13:04:03 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > After merging the driver-core tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/of/platform.c:674:12: warning: 'of_link_to_suppliers' defined but not used [-Wunused-function]
> >  static int of_link_to_suppliers(struct device *dev)
> >             ^~~~~~~~~~~~~~~~~~~~
> >
> > Introduced by commit
> >
> >   690ff7881b26 ("of/platform: Add functional dependency link from DT bindings")
>
> It also produced this warning:
>
> drivers/of/platform.c: In function 'of_link_property':
> drivers/of/platform.c:650:18: warning: ?: using integer constants in boolean context [-Wint-in-bool-context]
>   return done ? 0 : -ENODEV;
>

Thanks for reporting Stephen!

I'll fix the bool vs int thing right away. Weird that no other
compilation caught it.

As for the function not used, I'll move all the new code into the
already existing ifndef CONFIG_PPC for now.

Looks like PPC doesn't populate platform devices from DT using the
generic of_platform_default_populate_init() in drivers/of/platform.c.
I tried grepping around, but I don't see clearly where all the devices
are populated from DT for PPC. I'm not familiar with PPC, so if you or
someone else can give me a pointer to how devices are populated in
PPC, that's be helpful. If there's interest in this series for PPC,
I'd be happy to add support to however PPC populates the devices from
DT -- specifically, creating device links for devices as they are
populated.

Thanks,
Saravana