linux-kernel - Re: [PATCH] scsi/megaraid_sas: fix a compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B961A6AE-2377-406C-891D-4363DCD9827C@lca.pw>
Date:   Mon, 5 Aug 2019 23:27:32 -0400
From:   Qian Cai <cai@....pw>
To:     martin.petersen@...cle.com
Cc:     jejb@...ux.ibm.com, Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        shivasharan.srikanteshwara@...adcom.com,
        megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi/megaraid_sas: fix a compilation warning

Ping. Please take a look at this trivial patch.

> On Jul 26, 2019, at 10:25 AM, Qian Cai <cai@....pw> wrote:
> 
> The commit de516379e85f ("scsi: megaraid_sas: changes to function
> prototypes") introduced a comilation warning due to it changed the
> function prototype of read_fw_status_reg() to take an instance pointer
> instead, but forgot to remove an unused variable.
> 
> drivers/scsi/megaraid/megaraid_sas_fusion.c: In function
> 'megasas_fusion_update_can_queue':
> drivers/scsi/megaraid/megaraid_sas_fusion.c:326:39: warning: variable
> 'reg_set' set but not used [-Wunused-but-set-variable]
>  struct megasas_register_set __iomem *reg_set;
>                                       ^~~~~~~
> Fixes: de516379e85f ("scsi: megaraid_sas: changes to function prototypes")
> Signed-off-by: Qian Cai <cai@....pw>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index a32b3f0fcd15..e8092d59d575 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -323,9 +323,6 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
> {
> 	u16 cur_max_fw_cmds = 0;
> 	u16 ldio_threshold = 0;
> -	struct megasas_register_set __iomem *reg_set;
> -
> -	reg_set = instance->reg_set;
> 
> 	/* ventura FW does not fill outbound_scratch_pad_2 with queue depth */
> 	if (instance->adapter_type < VENTURA_SERIES)
> -- 
> 1.8.3.1
>