linux-kernel - Re: [PATCH] loop: Add LOOP_SET_DIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJWu+oq9JLnbGdqy+362JZUzjv6PvuRTNwiarTQiEfizsY32hQ@mail.gmail.com>
Date:   Tue, 6 Aug 2019 18:25:42 -0400
From:   Joel Fernandes <joelaf@...gle.com>
To:     Alessio Balsini <balsini@...roid.com>
Cc:     "open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>, dvander@...il.com,
        Yifan Hong <elsk@...gle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Cc: Android Kernel" <kernel-team@...roid.com>
Subject: Re: [PATCH] loop: Add LOOP_SET_DIRECT_IO in compat ioctl

Hi Alessio,

On Tue, Aug 6, 2019 at 6:05 PM Alessio Balsini <balsini@...roid.com> wrote:
>
> Export LOOP_SET_DIRECT_IO as additional lo_compat_ioctl.
> The input argument for this ioctl is a single long, in the end converted
> to a 1-bit boolean. Compatibility is then preserved.
>
> Cc: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Alessio Balsini <balsini@...roid.com>

This looks Ok to me, but I believe the commit message should also
explain what was this patch "fixing", how was this lack of an "export"
noticed, why does it matter, etc as well.

thanks,

 - Joel


> ---
>  drivers/block/loop.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 3036883fc9f8..a7461f482467 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1755,6 +1755,7 @@ static int lo_compat_ioctl(struct block_device *bdev, fmode_t mode,
>         case LOOP_SET_FD:
>         case LOOP_CHANGE_FD:
>         case LOOP_SET_BLOCK_SIZE:
> +       case LOOP_SET_DIRECT_IO:
>                 err = lo_ioctl(bdev, mode, cmd, arg);
>                 break;
>         default:
> --
> 2.22.0.770.g0f2c4a37fd-goog
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@...roid.com.
>