linux-kernel - Re: [PATCH v3] nvme-pci: Support shared tags across queues for Apple 2018 controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198e51f1454720f15f0570e98203834eed11893f.camel@kernel.crashing.org>
Date:   Tue, 06 Aug 2019 15:24:19 +1000
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Keith Busch <keith.busch@...el.com>
Cc:     Keith Busch <kbusch@...nel.org>, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Paul Pawlowski <paul@...rm.io>,
        Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Minwoo Im <minwoo.im.dev@...il.com>,
        Damien Le Moal <Damien.LeMoal@....com>
Subject: Re: [PATCH v3] nvme-pci: Support shared tags across queues for
 Apple 2018 controllers

On Mon, 2019-08-05 at 07:49 -0600, Keith Busch wrote:
> > Ping ? I had another look today and I don't feel like mucking around
> > with all the AQ size logic, AEN magic tag etc... just for that sake of
> > that Apple gunk. I'm happy to have it give up IO tags, it doesn't seem
> > to make much of a difference in practice anyway.
> > 
> > But if you feel strongly about it, then I'll implement the "proper" way
> > sometimes this week, adding a way to shrink the AQ down to something
> > like 3 (one admin request, one async event (AEN), and the empty slot)
> > by making a bunch of the constants involved variables instead.
> 
> I don't feel too strongly about it. I think your patch is fine, so
> 
> Acked-by: Keith Busch <keith.busch@...el.com>

Thanks, I'll fold the test and respin this week.

Cheers,
Ben.