linux-kernel - Re: [PATCH] ia64:unwind: fix double free for mod->arch.init_unw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Aug 2019 09:58:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     chenzefeng <chenzefeng2@...wei.com>
Cc:     tony.luck@...el.com, fenghua.yu@...el.com,
        linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] ia64:unwind: fix double free for mod->arch.init_unw_table

On Tue, Aug 06, 2019 at 03:46:33PM +0800, chenzefeng wrote:
> The function free_module in file kernel/module.c as follow:
> 
> void free_module(struct module *mod) {
> 	......
> 	module_arch_cleanup(mod);
> 	......
> 	module_arch_freeing_init(mod);
> 	......
> }
> 
> Both module_arch_cleanup and module_arch_freeing_init function
> would free the mod->arch.init_unw_table, which cause double free.
> 
> Here, set mod->arch.init_unw_table = NULL after remove the unwind
> table to avoid double free.
> 
> Signed-off-by: chenzefeng <chenzefeng2@...wei.com>
> ---
>  arch/ia64/kernel/module.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>