linux-kernel - Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65afeaaf-f703-02f2-a918-90a8bb8f58b6@linaro.org>
Date:   Tue, 6 Aug 2019 11:03:31 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     fugang.duan@....com, shawnguo@...nel.org, s.hauer@...gutronix.de
Cc:     gregkh@...uxfoundation.org, kernel@...gutronix.de,
        festevam@...il.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH nvmem 1/1] nvmem: imx: add i.MX8QM platform support



On 04/07/2019 15:20, fugang.duan@....com wrote:
> From: Fugang Duan <fugang.duan@....com>
> 
> i.MX8QM efuse table has some difference with i.MX8QXP platform,
> so add i.MX8QM platform support.
> 
> Signed-off-by: Fugang Duan <fugang.duan@....com>
> ---
>   drivers/nvmem/imx-ocotp-scu.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/nvmem/imx-ocotp-scu.c b/drivers/nvmem/imx-ocotp-scu.c
> index be2f5f0..0d78ab4 100644
> --- a/drivers/nvmem/imx-ocotp-scu.c
> +++ b/drivers/nvmem/imx-ocotp-scu.c
> @@ -16,6 +16,7 @@
>   
>   enum ocotp_devtype {
>   	IMX8QXP,
> +	IMX8QM,
>   };
>   
>   struct ocotp_devtype_data {
> @@ -39,6 +40,11 @@ static struct ocotp_devtype_data imx8qxp_data = {
>   	.nregs = 800,
>   };
>   
> +static struct ocotp_devtype_data imx8qm_data = {
> +	.devtype = IMX8QM,
> +	.nregs = 800,
> +};
> +
>   static int imx_sc_misc_otp_fuse_read(struct imx_sc_ipc *ipc, u32 word,
>   				     u32 *val)
>   {
> @@ -118,6 +124,7 @@ static struct nvmem_config imx_scu_ocotp_nvmem_config = {
>   
>   static const struct of_device_id imx_scu_ocotp_dt_ids[] = {
>   	{ .compatible = "fsl,imx8qxp-scu-ocotp", (void *)&imx8qxp_data },
> +	{ .compatible = "fsl,imx8qm-scu-ocotp", (void *)&imx8qm_data },
>   	{ },

Looks like you forgot to add this new compatible to device tree bindings 
at ./Documentation/devicetree/bindings/nvmem/imx-ocotp.txt or forgot to 
add me to CC.

Please resend the patch with it, I can not apply this as it is.

Thanks,
srini

>   };
>   MODULE_DEVICE_TABLE(of, imx_scu_ocotp_dt_ids);
>