linux-kernel - Re: [PATCH] ALSA: usb-audio: fix a memory leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h5znao9jb.wl-tiwai@suse.de>
Date:   Tue, 06 Aug 2019 12:47:20 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Wenwen Wang <wenwen@...uga.edu>
Cc:     "moderated list:SOUND" <alsa-devel@...a-project.org>,
        Shuah Khan <shuah@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Richard Fontana <rfontana@...hat.com>,
        Takashi Iwai <tiwai@...e.com>,
        open list <linux-kernel@...r.kernel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH] ALSA: usb-audio: fix a memory leak bug

On Tue, 06 Aug 2019 09:00:27 +0200,
Wenwen Wang wrote:
> 
> In snd_usb_get_audioformat_uac3(), a structure for channel maps 'chmap' is
> allocated through kzalloc() before the execution goto 'found_clock'.
> However, this structure is not deallocated if the memory allocation for
> 'pd' fails, leading to a memory leak bug.
> 
> To fix the above issue, free 'fp->chmap' before returning NULL.
> 
> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>

Applied, thanks.


Takashi