linux-kernel - Re: [PATCH] watchdog: jz4740: Fix unused variable warning in jz4740_wdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c93e60f-4122-282c-db28-0b6dd64af3d5@roeck-us.net>
Date:   Tue, 6 Aug 2019 04:04:07 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: jz4740: Fix unused variable warning in
 jz4740_wdt_probe

On 8/6/19 12:39 AM, Gustavo A. R. Silva wrote:
> Fix the following warning (Building: ci20_defconfig mips):
> 
> drivers/watchdog/jz4740_wdt.c: In function ‘jz4740_wdt_probe’:
> drivers/watchdog/jz4740_wdt.c:165:6: warning: unused variable ‘ret’ [-Wunused-variable]
>    int ret;
>        ^~~
> Fixes: 9ee644c9326c ("watchdog: jz4740_wdt: drop warning after registering device")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/jz4740_wdt.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/jz4740_wdt.c b/drivers/watchdog/jz4740_wdt.c
> index d4a90916dd38..c6052ae54f32 100644
> --- a/drivers/watchdog/jz4740_wdt.c
> +++ b/drivers/watchdog/jz4740_wdt.c
> @@ -162,7 +162,6 @@ static int jz4740_wdt_probe(struct platform_device *pdev)
>   	struct device *dev = &pdev->dev;
>   	struct jz4740_wdt_drvdata *drvdata;
>   	struct watchdog_device *jz4740_wdt;
> -	int ret;
>   
>   	drvdata = devm_kzalloc(dev, sizeof(struct jz4740_wdt_drvdata),
>   			       GFP_KERNEL);
>