linux-kernel - Re: [PATCH v2] perf diff: Report noisy for cycles diff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <085edaa4-e8f2-f501-5ffc-4d07b4ea85ad@linux.intel.com>
Date:   Tue, 6 Aug 2019 19:39:20 +0800
From:   "Jin, Yao" <yao.jin@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v2] perf diff: Report noisy for cycles diff



On 8/6/2019 4:34 PM, Jiri Olsa wrote:
> On Thu, Jul 25, 2019 at 06:14:32AM +0800, Jin Yao wrote:
> 
> SNIP
> 
>> +}
>> +
>>   double avg_stats(struct stats *stats)
>>   {
>>   	return stats->mean;
>> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
>> index 95b4de7a9d51..3448d319a220 100644
>> --- a/tools/perf/util/stat.h
>> +++ b/tools/perf/util/stat.h
>> @@ -8,14 +8,18 @@
>>   #include <sys/time.h>
>>   #include <sys/resource.h>
>>   #include <sys/wait.h>
>> +#include <stdio.h>
>>   #include "xyarray.h"
>>   #include "rblist.h"
>>   #include "perf.h"
>>   #include "event.h"
>>   
>> +#define NUM_SPARK_VALS	8 /* support spark line on first N items */
>> +
>>   struct stats {
>>   	double n, mean, M2;
>>   	u64 max, min;
>> +	unsigned long svals[NUM_SPARK_VALS];
>>   };
> 
> please do it without changing the 'struct stats', it's all
> over the place and diff would be the only user
> 
> thanks
> jirka
> 

OK, I see. I will save the svals[] in other struct.

Thanks
Jin Yao