linux-kernel - Re: [PATCH] Revert "mwifiex: fix system hang problem after resume"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190806124341.AC16760590@smtp.codeaurora.org>
Date:   Tue,  6 Aug 2019 12:43:41 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Amitkumar Karwar <amitkarwar@...il.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        Ganapathi Bhat <gbhat@...vell.com>,
        Xinming Hu <huxinming820@...il.com>,
        linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Doug Anderson <dianders@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Brian Norris <briannorris@...omium.org>,
        Amitkumar Karwar <akarwar@...vell.com>
Subject: Re: [PATCH] Revert "mwifiex: fix system hang problem after resume"

Brian Norris <briannorris@...omium.org> wrote:

> This reverts commit 437322ea2a36d112e20aa7282c869bf924b3a836.
> 
> This above-mentioned "fix" does not actually do anything to prevent a
> race condition. It simply papers over it so that the issue doesn't
> appear.
> 
> If this is a real problem, it should be explained better than the above
> commit does, and an alternative, non-racy solution should be found.
> 
> For further reason to revert this: there's no reason we can't try
> resetting the card when it's *actually* stuck in host-sleep mode. So
> instead, this is unnecessarily creating scenarios where we can't recover
> Wifi (and in fact, I'm fielding reports of Chromebooks that can't
> recover after the aforementioned commit).
> 
> Note that this was proposed in 2017 and Ack'ed then, but due to my
> marking as RFC, it never went anywhere:
> 
> https://patchwork.kernel.org/patch/9657277/
> [RFC] Revert "mwifiex: fix system hang problem after resume"
> 
> Cc: Amitkumar Karwar <akarwar@...vell.com>
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Acked-by: Amitkumar Karwar <amitkarwar@...il.com>
> Tested-by: Matthias Kaehlcke <mka@...omium.org>

Patch applied to wireless-drivers-next.git, thanks.

654026df2635 Revert "mwifiex: fix system hang problem after resume"

-- 
https://patchwork.kernel.org/patch/11077645/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches