linux-kernel - Re: [PATCH] sched/core: decrease rq->nr_uninterruptible before set_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190806141922.GT2332@hirez.programming.kicks-ass.net>
Date:   Tue, 6 Aug 2019 16:19:22 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Cheng Jian <cj.chengjian@...wei.com>
Cc:     mingo@...hat.com, xiexiuqi@...wei.com, huawei.libin@...wei.com,
        bobo.shaobowang@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/core: decrease rq->nr_uninterruptible before
 set_task_cpu

On Tue, Aug 06, 2019 at 10:12:50PM +0800, Cheng Jian wrote:
> Migration may occur when wake up a process, so we must update
> the rq->nr_uninterruptible before set_task_cpu, otherwise we
> will decrease the nr_interuptible of the incorrect rq. Over
> time, it cause some rq accounting according to be too large,
> but others are negative.
> 
> Also change the type of rq->nr_uninterruptible to atomic_t.

NAK. Also there is no actual problem description there.