linux-kernel - Re: [PATCH 6/6] arm64: dts: meson-g12b-khadas-vim3: add initial device-tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <198d9d59-78bd-1092-69dd-9dde62915ac5@baylibre.com>
Date:   Tue, 6 Aug 2019 17:48:55 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     khilman@...libre.com, linux-amlogic@...ts.infradead.org,
        Christian Hewitt <christianshewitt@...il.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 6/6] arm64: dts: meson-g12b-khadas-vim3: add initial
 device-tree

On 03/08/2019 20:50, Martin Blumenstingl wrote:
> On Wed, Jul 31, 2019 at 2:44 PM Neil Armstrong <narmstrong@...libre.com> wrote:
> [...]
>> +       memory@0 {
>> +               device_type = "memory";
>> +               reg = <0x0 0x0 0x0 0x40000000>;
> nit-pick: we typically use the memory size used in the board size with
> the lowest amount of RAM - 2GiB in this case. so I would change it to
> 0x80000000

Right

> 
> [...]
>> +       leds {
>> +               compatible = "gpio-leds";
>> +
>> +               white {
>> +                       label = "vim3:white";
> downstream sources use label="sys_led"
> should we call it vim3:white:sys?
> 

OK, no problem
Thanks for the review.

Neil