linux-kernel - Re: [PATCH] PCI: use PCI_SRIOV_NUM_BARS in loops instead of PCI_IOV_RESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3322ea7f-c4c7-0dc0-73bd-778f57cc9450@linux.intel.com>
Date:   Tue, 6 Aug 2019 10:26:21 -0700
From:   sathyanarayanan kuppuswamy 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Denis Efremov <efremov@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: use PCI_SRIOV_NUM_BARS in loops instead of
 PCI_IOV_RESOURCE_END


On 8/6/19 7:07 AM, Denis Efremov wrote:
> It's a general pattern to write loops with 'i < PCI_SRIOV_NUM_BARS'
> condition. This patch fixes remaining loops which violates this implicit
> agreement.

Looks good to me.

Reviewed-by: Kuppuswamy Sathyanarayanan 
<sathyanarayanan.kuppuswamy@...ux.intel.com>

>
> Signed-off-by: Denis Efremov <efremov@...ux.com>
> ---
>   drivers/pci/iov.c       | 4 ++--
>   drivers/pci/setup-bus.c | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 525fd3f272b3..9b48818ced01 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -557,8 +557,8 @@ static void sriov_restore_state(struct pci_dev *dev)
>   	ctrl |= iov->ctrl & PCI_SRIOV_CTRL_ARI;
>   	pci_write_config_word(dev, iov->pos + PCI_SRIOV_CTRL, ctrl);
>   
> -	for (i = PCI_IOV_RESOURCES; i <= PCI_IOV_RESOURCE_END; i++)
> -		pci_update_resource(dev, i);
> +	for (i = 0; i < PCI_SRIOV_NUM_BARS; i++)
> +		pci_update_resource(dev, i + PCI_IOV_RESOURCES);
>   
>   	pci_write_config_dword(dev, iov->pos + PCI_SRIOV_SYS_PGSIZE, iov->pgsz);
>   	pci_iov_set_numvfs(dev, iov->num_VFs);
> diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> index 79b1fa6519be..e7dbe21705ba 100644
> --- a/drivers/pci/setup-bus.c
> +++ b/drivers/pci/setup-bus.c
> @@ -1662,8 +1662,8 @@ static int iov_resources_unassigned(struct pci_dev *dev, void *data)
>   	int i;
>   	bool *unassigned = data;
>   
> -	for (i = PCI_IOV_RESOURCES; i <= PCI_IOV_RESOURCE_END; i++) {
> -		struct resource *r = &dev->resource[i];
> +	for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) {
> +		struct resource *r = &dev->resource[i + PCI_IOV_RESOURCES];
>   		struct pci_bus_region region;
>   
>   		/* Not assigned or rejected by kernel? */

-- 
Sathyanarayanan Kuppuswamy
Linux kernel developer