linux-kernel - Re: [PATCH] net/ipv4: reset mac head before call ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190806.114351.538219207946033327.davem@davemloft.net>
Date:   Tue, 06 Aug 2019 11:43:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ptpt52@...il.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/ipv4: reset mac head before call ip_tunnel_rcv()

From: Chen Minqiang <ptpt52@...il.com>
Date: Tue,  6 Aug 2019 18:47:31 +0800

> Signed-off-by: Chen Minqiang <ptpt52@...il.com>

No commit message means I'm not even going to look at this patch and
try to understand it.

You must always completely explain, in detail, what change you are
making, how you are making it, and above all why you are making this
change.

Is there some bug you are fixing?  What is that bug and what does that
bug cause to happen?  Are there potential negative side effects to
your fix?  What are they and what was the cost/benefit analysis for
that?

Where was the bug introduced?  You must provide a proper Fixes: tag
which shows this.

Thank you.