linux-kernel - [PATCH v2 2/2] drivers/ras/debugfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7168.1565218769@turing-police>
Date:   Wed, 07 Aug 2019 18:59:29 -0400
From:   "Valdis Klētnieks" <valdis.kletnieks@...edu>
To:     Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>
cc:     linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2 2/2] drivers/ras/debugfs.c - fix prototype warnings

When building with C=2 and/or W=1, legitimate warnings are issued
about missing prototypes.  Provide the proper includes.

  CHECK   drivers/ras/debugfs.c
drivers/ras/debugfs.c:4:15: warning: symbol 'ras_debugfs_dir' was not declared. Should it be static?
drivers/ras/debugfs.c:8:5: warning: symbol 'ras_userspace_consumers' was not declared. Should it be static?
drivers/ras/debugfs.c:38:12: warning: symbol 'ras_add_daemon_trace' was not declared. Should it be static?
drivers/ras/debugfs.c:54:13: warning: symbol 'ras_debugfs_init' was not declared. Should it be static?
  CC      drivers/ras/debugfs.o
drivers/ras/debugfs.c:8:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
    8 | int ras_userspace_consumers(void)
      |     ^~~~~~~~~~~~~~~~~~~~~~~
drivers/ras/debugfs.c:38:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
   38 | int __init ras_add_daemon_trace(void)
      |            ^~~~~~~~~~~~~~~~~~~~
drivers/ras/debugfs.c:54:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
   54 | void __init ras_debugfs_init(void)
      |             ^~~~~~~~~~~~~~~~

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@...edu>

diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index 9c1b717efad8..0d4f985afbf3 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0-only
 #include <linux/debugfs.h>
+#include <linux/ras.h>
+#include "debugfs.h"
 
 struct dentry *ras_debugfs_dir;