linux-kernel - Re: [PATCH 5.2 03/20] ALSA: usb-audio: Sanity checks for each pipe and EP types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190807023808.GS17747@sasha-vm>
Date:   Tue, 6 Aug 2019 22:38:08 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        syzbot+d952e5e28f5fb7718d23@...kaller.appspotmail.com,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 5.2 03/20] ALSA: usb-audio: Sanity checks for each pipe
 and EP types

On Fri, Aug 02, 2019 at 05:51:54PM +0200, Greg Kroah-Hartman wrote:
>On Fri, Aug 02, 2019 at 09:48:28AM -0400, Sasha Levin wrote:
>> On Fri, Aug 02, 2019 at 11:39:57AM +0200, Greg Kroah-Hartman wrote:
>> > From: Takashi Iwai <tiwai@...e.de>
>> >
>> > commit 801ebf1043ae7b182588554cc9b9ad3c14bc2ab5 upstream.
>> >
>> > The recent USB core code performs sanity checks for the given pipe and
>> > EP types, and it can be hit by manipulated USB descriptors by syzbot.
>> > For making syzbot happier, this patch introduces a local helper for a
>> > sanity check in the driver side and calls it at each place before the
>> > message handling, so that we can avoid the WARNING splats.
>> >
>> > Reported-by: syzbot+d952e5e28f5fb7718d23@...kaller.appspotmail.com
>> > Signed-off-by: Takashi Iwai <tiwai@...e.de>
>> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>>
>> This commit has a fix: 5d78e1c2b7f4b ("ALSA: usb-audio: Fix gpf in
>> snd_usb_pipe_sanity_check") which was not pulled by Linus yet.
>>
>> I'm going to drop this commit and re-queue it together with it's fix
>> once it makes it upstream.
>
>Ah, thanks for doing that.

Now queued these two commits for 5.2.

--
Thanks,
Sasha