linux-kernel - Re: [PATCH RFC tip/core/rcu 02/14] rcu/nocb: Add bypass callback queueing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Aug 2019 20:47:57 -0700
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Joel Fernandes <joel@...lfernandes.org>, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org, mingo@...nel.org,
        jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        dhowells@...hat.com, edumazet@...gle.com, fweisbec@...il.com,
        oleg@...hat.com
Subject: Re: [PATCH RFC tip/core/rcu 02/14] rcu/nocb: Add bypass callback
 queueing

On Tue, Aug 06, 2019 at 09:24:15PM -0400, Steven Rostedt wrote:
> On Tue, 6 Aug 2019 18:17:07 -0700
> "Paul E. McKenney" <paulmck@...ux.ibm.com> wrote:
> 
> > On Tue, Aug 06, 2019 at 08:40:55PM -0400, Steven Rostedt wrote:
> > > On Tue, 6 Aug 2019 17:35:01 -0700
> > > "Paul E. McKenney" <paulmck@...ux.ibm.com> wrote:
> > >   
> > > > > > +	// Don't use ->nocb_bypass during early boot.    
> > > > > 
> > > > > Very minor nit: comment style should be /* */    
> > > > 
> > > > I thought that Linus said that "//" was now OK.  Am I confused?  
> > > 
> > > Have a link?  
> > 
> > https://lkml.org/lkml/2016/7/8/625
> 
>   The (c) form is particularly good for things like enum or structure
>   member comments at the end of code, where you might want to align
>   things up, but the ending comment marker ends up being visually pretty
>   distracting (and lining _that_ up is too much make-believe work).
> 
> I think it's still for special occasions, and the above example doesn't
> look like one of them ;-)

It does say "particularly good for", not "only good for.  ;-)

> I basically avoid the '//' comment, as it just adds inconstancy.

It saves me two whacks on the shift key and three whacks on other
keys.  ;-)

							Thanx, Paul