linux-kernel - Re: [PATCH] ALSA: usb-midi: fix a memory leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hef1xo81o.wl-tiwai@suse.de>
Date:   Wed, 07 Aug 2019 07:31:47 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Wenwen Wang <wenwen@...uga.edu>
Cc:     "moderated list:SOUND" <alsa-devel@...a-project.org>,
        Clemens Ladisch <clemens@...isch.de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-midi: fix a memory leak bug

On Wed, 07 Aug 2019 05:22:09 +0200,
Wenwen Wang wrote:
> 
> In __snd_usbmidi_create(), a MIDI streaming interface structure is
> allocated through kzalloc() and the pointer is saved to 'umidi'. Later on,
> the endpoint structures are created by invoking
> snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints(),
> depending on the type of the audio quirk type. However, if the creation
> fails, the allocated 'umidi' is not deallocated, leading to a memory leak
> bug.
> 
> To fix the above issue, free 'umidi' before returning the error.
> 
> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>

It's again a false-positive report.  The object is released
automatically by the destructor of its base snd_rawmidi object.


thanks,

Takashi