linux-kernel - Re: [PATCH] cpufreq: schedutil: fix equation in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13854122.nn4VJ8hDQq@kreacher>
Date:   Wed, 07 Aug 2019 11:42:11 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Qais Yousef <qais.yousef@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Ingo Molnar <mingo@...hat.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: schedutil: fix equation in comment

On Monday, August 5, 2019 3:06:20 PM CEST Peter Zijlstra wrote:
> On Fri, Aug 02, 2019 at 11:46:28AM +0100, Qais Yousef wrote:
> > scale_irq_capacity() call in schedutil_cpu_util() does
> > 
> > 	util *= (max - irq)
> > 	util /= max
> > 
> > But the comment says
> > 
> > 	util *= (1 - irq)
> > 	util /= max
> > 
> > Fix the comment to match what the scaling function does.
> > 
> > Signed-off-by: Qais Yousef <qais.yousef@....com>
> 
> Thanks!
> 

I've applied this, so please let me know if it has gone into -tip too and I'll drop it then.