linux-kernel - Re: [PATCH] arm64/ptrace: Fix typoes in sve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190807103810.GF10425@arm.com>
Date:   Wed, 7 Aug 2019 11:38:10 +0100
From:   Dave Martin <Dave.Martin@....com>
To:     Julien Grall <julien.grall@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        catalin.marinas@....com, will@...nel.org, oleg@...hat.com
Subject: Re: [PATCH] arm64/ptrace: Fix typoes in sve_set() comment

On Wed, Aug 07, 2019 at 11:34:45AM +0100, Julien Grall wrote:
> The ptrace trace SVE flags are prefixed with SVE_PT_*. Update the
> comment accordingly.
> 
> Signed-off-by: Julien Grall <julien.grall@....com>
> ---
>  arch/arm64/kernel/ptrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c
> index 17525da8d5c8..0de3eae09d36 100644
> --- a/arch/arm64/kernel/ptrace.c
> +++ b/arch/arm64/kernel/ptrace.c
> @@ -870,7 +870,7 @@ static int sve_set(struct task_struct *target,
>  		goto out;
>  
>  	/*
> -	 * Apart from PT_SVE_REGS_MASK, all PT_SVE_* flags are consumed by
> +	 * Apart from SVE_PT_REGS_MASK, all SVE_PT_* flags are consumed by
>  	 * sve_set_vector_length(), which will also validate them for us:
>  	 */

Thanks for spotting that.

Reviewed-by: Dave Martin <Dave.Martin@....com>

Cheers
---Dave