linux-kernel - Re: [PATCH v8 1/3] PM / wakeup: Drop wakeup_source_init(), wakeup_source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 7 Aug 2019 13:09:59 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tri Vo <trong@...roid.com>
Cc:     rjw@...ysocki.net, viresh.kumar@...aro.org, rafael@...nel.org,
        hridya@...gle.com, sspatil@...gle.com, kaleshsingh@...gle.com,
        ravisadineni@...omium.org, swboyd@...omium.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        kernel-team@...roid.com
Subject: Re: [PATCH v8 1/3] PM / wakeup: Drop wakeup_source_init(),
 wakeup_source_prepare()

On Tue, Aug 06, 2019 at 06:48:44PM -0700, Tri Vo wrote:
> wakeup_source_init() has no users. Remove it.
> 
> As a result, wakeup_source_prepare() is only called from
> wakeup_source_create(). Merge wakeup_source_prepare() into
> wakeup_source_create() and remove it.
> 
> Change wakeup_source_create() behavior so that assigning NULL to wakeup
> source's name throws an error.

The kernel C code can not "throw" errors :)

Anyway, odd verbage asside, patch looks good to me:

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>