linux-kernel - [tip:x86/urgent] x86: mtrr: cyrix: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 7 Aug 2019 06:17:09 -0700
From:   "tip-bot for Gustavo A. R. Silva" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     gustavo@...eddedor.com, keescook@...omium.org, hpa@...or.com,
        tglx@...utronix.de, linux-kernel@...r.kernel.org, mingo@...nel.org
Subject: [tip:x86/urgent] x86: mtrr: cyrix: Mark expected switch
 fall-through

Commit-ID:  7468a4eae541ce5aff65595aa502aa0a4def6615
Gitweb:     https://git.kernel.org/tip/7468a4eae541ce5aff65595aa502aa0a4def6615
Author:     Gustavo A. R. Silva <gustavo@...eddedor.com>
AuthorDate: Mon, 5 Aug 2019 15:17:12 -0500
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Wed, 7 Aug 2019 15:12:01 +0200

x86: mtrr: cyrix: Mark expected switch fall-through

Mark switch cases where we are expecting to fall through.

Fix the following warning (Building: i386_defconfig i386):

arch/x86/kernel/cpu/mtrr/cyrix.c:99:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Reviewed-by: Kees Cook <keescook@...omium.org>
Link: https://lkml.kernel.org/r/20190805201712.GA19927@embeddedor

---
 arch/x86/kernel/cpu/mtrr/cyrix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/cpu/mtrr/cyrix.c b/arch/x86/kernel/cpu/mtrr/cyrix.c
index 4296c702a3f7..72182809b333 100644
--- a/arch/x86/kernel/cpu/mtrr/cyrix.c
+++ b/arch/x86/kernel/cpu/mtrr/cyrix.c
@@ -98,6 +98,7 @@ cyrix_get_free_region(unsigned long base, unsigned long size, int replace_reg)
 	case 7:
 		if (size < 0x40)
 			break;
+		/* Else, fall through */
 	case 6:
 	case 5:
 	case 4: