linux-kernel - Re: [PATCH v6 23/57] irqchip: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c850747f-095d-a33c-c276-f1ee7166671a@arm.com>
Date:   Wed, 7 Aug 2019 15:23:09 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Stephen Boyd <swboyd@...omium.org>, linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v6 23/57] irqchip: Remove dev_err() usage after
 platform_get_irq()

Hi Stephen,

On 30/07/2019 19:15, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
> 
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
> 
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
> 
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
> 
> While we're here, remove braces on if statements that only have one
> statement (manually).
> 
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jason Cooper <jason@...edaemon.net>
> Cc: Marc Zyngier <marc.zyngier@....com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
> 
> Please apply directly to subsystem trees
> 
>  drivers/irqchip/irq-imgpdc.c        | 8 ++------
>  drivers/irqchip/irq-keystone.c      | 4 +---
>  drivers/irqchip/qcom-irq-combiner.c | 4 +---
>  3 files changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c
> index d00489a4b54f..698d07f48fed 100644
> --- a/drivers/irqchip/irq-imgpdc.c
> +++ b/drivers/irqchip/irq-imgpdc.c
> @@ -362,10 +362,8 @@ static int pdc_intc_probe(struct platform_device *pdev)
>  	}
>  	for (i = 0; i < priv->nr_perips; ++i) {
>  		irq = platform_get_irq(pdev, 1 + i);
> -		if (irq < 0) {
> -			dev_err(&pdev->dev, "cannot find perip IRQ #%u\n", i);
> +		if (irq < 0)

There's a bug here. irq == 0 *is* an error. Same thing for the next two
hunks. Nothing wrong with your patch though.

I guess I'll fix it on top as I apply it.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...