linux-kernel - Re: [PATCH] firmware: google: update vpd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d4ae764.1c69fb81.f81f8.054c@mx.google.com>
Date:   Wed, 07 Aug 2019 07:59:47 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Hung-Te Lin <hungte@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Anton Vasilyev <vasilyev@...ras.ru>,
        Colin Ian King <colin.king@...onical.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Samuel Holland <samuel@...lland.org>,
        Allison Randal <allison@...utok.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: google: update vpd_decode from upstream

Quoting Guenter Roeck (2019-08-07 06:58:34)
> On Fri, Aug 02, 2019 at 03:27:54PM -0700, Stephen Boyd wrote:
> > Quoting Hung-Te Lin (2019-08-02 01:20:31)
> > >  
> > > -static int vpd_section_attrib_add(const u8 *key, s32 key_len,
> > > -                                 const u8 *value, s32 value_len,
> > > +static int vpd_section_attrib_add(const u8 *key, u32 key_len,
> > > +                                 const u8 *value, u32 value_len,
> > >                                   void *arg)
> > >  {
> > >         int ret;
> > > @@ -246,7 +246,7 @@ static int vpd_section_destroy(struct vpd_section *sec)
> > >  
> > >  static int vpd_sections_init(phys_addr_t physaddr)
> > >  {
> > > -       struct vpd_cbmem *temp;
> > > +       struct vpd_cbmem __iomem *temp;
> 
> The change to __iomem should also be a separate patch.
> 

Please don't change it back to __iomem. See commit ae21f41e1f56
("firmware: vpd: Drop __iomem usage for memremap() memory") for why.