linux-kernel - Re: [PATCH v2] selftests: kvm: Adding config fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6b4f179-1fef-65db-8125-fa60e3627656@kernel.org>
Date:   Wed, 7 Aug 2019 09:52:27 -0600
From:   shuah <shuah@...nel.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>, pbonzini@...hat.com,
        linux-kernel@...r.kernel.org, drjones@...hat.com,
        sean.j.christopherson@...el.com, linux-kselftest@...r.kernel.org,
        kvm@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH v2] selftests: kvm: Adding config fragments

Hi Naresh,

On 8/7/19 7:58 AM, Naresh Kamboju wrote:
> selftests kvm test cases need pre-required kernel configs for the test
> to get pass.
> 

Can you elaborate and add more information on which tests fail without
these configs. I am all for adding configs, however I would like to
see more information explaining which tests don't pass without this
change.

> Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> ---
>   tools/testing/selftests/kvm/config | 3 +++
>   1 file changed, 3 insertions(+)
>   create mode 100644 tools/testing/selftests/kvm/config
> 
> diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config
> new file mode 100644
> index 000000000000..63ed533f73d6
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/config
> @@ -0,0 +1,3 @@
> +CONFIG_KVM=y
> +CONFIG_KVM_INTEL=y
> +CONFIG_KVM_AMD=y
> 

That being said, it is up to Paolo to decide a call on this patch.

thanks,
-- Shuah