linux-kernel - Re: [PATCH v2] selftests: kvm: Adding config fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ace07599-7805-a75f-3af2-b61a5fb4053b@kernel.org>
Date:   Wed, 7 Aug 2019 10:25:22 -0600
From:   shuah <shuah@...nel.org>
To:     Paolo Bonzini <pbonzini@...hat.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        linux-kernel@...r.kernel.org, drjones@...hat.com,
        sean.j.christopherson@...el.com, linux-kselftest@...r.kernel.org,
        kvm@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH v2] selftests: kvm: Adding config fragments

On 8/7/19 10:19 AM, Paolo Bonzini wrote:
> On 07/08/19 17:52, shuah wrote:
>>
>>
>> On 8/7/19 7:58 AM, Naresh Kamboju wrote:
>>> selftests kvm test cases need pre-required kernel configs for the test
>>> to get pass.
>>>
>>
>> Can you elaborate and add more information on which tests fail without
>> these configs. I am all for adding configs, however I would like to
>> see more information explaining which tests don't pass without this
>> change.
> 
> The KVM tests are skipped without these configs:
> 
>          dev_fd = open(KVM_DEV_PATH, O_RDONLY);
>          if (dev_fd < 0)
>                  exit(KSFT_SKIP);
> 

Thanks Paolo!

This would be great info. to add to the commit log.

thanks,
-- Shuah