linux-kernel - Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <213c75dd-e5a7-4536-9c3f-89825278dcfb@oracle.com>
Date:   Wed, 7 Aug 2019 11:13:36 -0700
From:   Divya Indi <divya.indi@...cle.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Joe Jin <joe.jin@...cle.com>,
        Aruna Ramakrishna <aruna.ramakrishna@...cle.com>,
        Srinivas Eeda <srinivas.eeda@...cle.com>
Subject: Re: [PATCH 7/7] tracing: Un-export ftrace_set_clr_event

Hi Steven,

On 8/2/19 2:25 PM, Steven Rostedt wrote:
> On Fri, 2 Aug 2019 14:12:54 -0700
> Divya Indi <divya.indi@...cle.com> wrote:
>
>> Hi Steve,
>>
>> The first patch would be like a temporary fix in case we need more
>> changes to the patches that add the new function - trace_array_set_clr()
>> and unexport ftrace_set_clr_event() and might take some time. In which
>> case I think it would be good to have this in place (But, not part of
>> this series).
>>
>> If they all are to go in together as part of the same release ie if all
>> is good with the concerned patches (Patch 6 & Patch 7), then I think
>> having this patch would be meaningless.
> Can you just do this part of patch 6 instead?

Yes, will merge the two ie -

1)  Add 2 new functions - trace_array_set_clr_event(), trace_array_lookup()

2)  Unexport ftrace_set_clr_event.

into a single patch.


Thanks,

Divya

>
> +/**
> + * trace_array_set_clr_event - enable or disable an event for a trace array
> + * @system: system name to match (NULL for any system)
> + * @event: event name to match (NULL for all events, within system)
> + * @set: 1 to enable, 0 to disable
> + *
> + * This is a way for other parts of the kernel to enable or disable
> + * event recording to instances.
> + *
> + * Returns 0 on success, -EINVAL if the parameters do not match any
> + * registered events.
> + */
> +int trace_array_set_clr_event(struct trace_array *tr, const char *system,
> +		const char *event, int set)
> +{
> +	if (!tr)
> +		return -ENOENT;
> +
> +	return __ftrace_set_clr_event(tr, NULL, system, event, set);
> +}
> +EXPORT_SYMBOL_GPL(trace_array_set_clr_event);
> +
>
> -- Steve