linux-kernel - Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190807190320.th4sbnsnmwb7myzx@linux.intel.com>
Date:   Wed, 7 Aug 2019 22:03:44 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sumit Garg <sumit.garg@...aro.org>
Cc:     keyrings@...r.kernel.org, linux-integrity@...r.kernel.org,
        linux-crypto@...r.kernel.org,
        linux-security-module@...r.kernel.org, dhowells@...hat.com,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        peterhuewe@....de, jgg@...pe.ca, jejb@...ux.ibm.com, arnd@...db.de,
        gregkh@...uxfoundation.org, zohar@...ux.ibm.com, jmorris@...ei.org,
        serge@...lyn.com, casey@...aufler-ca.com,
        ard.biesheuvel@...aro.org, daniel.thompson@...aro.org,
        linux-kernel@...r.kernel.org, tee-dev@...ts.linaro.org
Subject: Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code

On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote:
> Move TPM2 trusted keys code to trusted keys subsystem.

Missing a long description. The reason is that it is better consolidate
all trusted keys code to a single location so that it can be maintained
sanely and it should be stated here.

> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@...aro.org>

I would suggest adding at least two commits before this:

- A commit that just exports tpm_buf stuff and TPM2 constants to
  include/linux
- A commit that just changes the existing TPM 1.x trusted keys
  code to use tpm_buf.

These should be before the current 1/3 commit.

/Jarkko