linux-kernel - Re: [PATCH] clk: fix devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1908082151160.2912@hadrien>
Date:   Thu, 8 Aug 2019 21:51:35 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Stephen Boyd <sboyd@...nel.org>
cc:     Jonas Gorski <jonas.gorski@...il.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Michael Turquette <mturquette@...libre.com>,
        Philippe Mathieu-Daud?? <f4bug@...at.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH] clk: fix devm_platform_ioremap_resource.cocci warnings



On Thu, 8 Aug 2019, Stephen Boyd wrote:

> Quoting Julia Lawall (2019-08-08 09:10:53)
> > From: kbuild test robot <lkp@...el.com>
> >
> > drivers/clk/bcm/clk-bcm63xx-gate.c:174:1-9: WARNING: Use devm_platform_ioremap_resource for hw -> regs
> >
> >  Use devm_platform_ioremap_resource helper which wraps
> >  platform_get_resource() and devm_ioremap_resource() together.
> >
> > Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
> >
> > Fixes: 1c099779c1e2 ("clk: add BCM63XX gated clock controller driver")
>
> Is it fixing anything? As far as I can tell it's reducing lines of code
> with another function.

No, it doesn't fix anything.

julia

>
> > CC: Jonas Gorski <jonas.gorski@...il.com>
> > Signed-off-by: kbuild test robot <lkp@...el.com>
> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
>
>