linux-kernel - Re: [Tee-dev] [RFC v2 2/6] tee: enable support to register kernel memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Aug 2019 17:26:58 -0500
From:   Stuart Yoder <stuart.yoder@....com>
To:     Sumit Garg <sumit.garg@...aro.org>, keyrings@...r.kernel.org,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org
Cc:     tee-dev@...ts.linaro.org, daniel.thompson@...aro.org,
        corbet@....net, jejb@...ux.ibm.com, ard.biesheuvel@...aro.org,
        linux-doc@...r.kernel.org, zohar@...ux.ibm.com,
        linux-kernel@...r.kernel.org, dhowells@...hat.com,
        jarkko.sakkinen@...ux.intel.com, casey@...aufler-ca.com,
        linux-arm-kernel@...ts.infradead.org, serge@...lyn.com
Subject: Re: [Tee-dev] [RFC v2 2/6] tee: enable support to register kernel
 memory



On 7/30/19 7:23 AM, Sumit Garg wrote:

> @@ -264,7 +266,17 @@ struct tee_shm *tee_shm_register(struct tee_context *ctx, unsigned long addr,
>   		goto err;
>   	}
>   
> -	rc = get_user_pages_fast(start, num_pages, FOLL_WRITE, shm->pages);
> +	if (flags & TEE_SHM_USER_MAPPED) {
> +		rc = get_user_pages_fast(start, num_pages, FOLL_WRITE,
> +					 shm->pages);
> +	} else {
> +		const struct kvec kiov = {
> +			.iov_base = (void *)start,
> +			.iov_len = PAGE_SIZE
> +		};
> +
> +		rc = get_kernel_pages(&kiov, num_pages, 0, shm->pages);

Passing a single kvec struct is temporary I assume?  Because as currently
written this will only work with num_pages==1.

Stuart