linux-kernel - Re: [alsa-devel] [PATCH] ALSA: firewire: fix a memory leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Aug 2019 18:04:03 +0900
From:   "Takashi Sakamoto" <o-takashi@...amocchi.jp>
To:     "Wenwen Wang" <wenwen@...uga.edu>
Cc:     "open list" <linux-kernel@...r.kernel.org>,
        "moderated list:FIREWIRE AUDIO DRIVERS" <alsa-devel@...a-project.org>,
        "Clemens Ladisch" <clemens@...isch.de>,
        "Takashi Iwai" <tiwai@...e.com>
Subject: Re: [alsa-devel] [PATCH] ALSA: firewire: fix a memory leak bug

Hi,

On Thu, Aug 8, 2019, at 14:53, Wenwen Wang wrote:
> In iso_packets_buffer_init(), 'b->packets' is allocated through
> kmalloc_array(). Then, the aligned packet size is checked. If it is
> larger than PAGE_SIZE, -EINVAL will be returned to indicate the error.
> However, the allocated 'b->packets' is not deallocated on this path,
> leading to a memory leak.
> 
> To fix the above issue, free 'b->packets' before returning the error code.
> 
> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>
> ---
>  sound/firewire/packets-buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>

And this bug exists till its first commit for v2.6.39.

Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave Surround driver")
Cc: <stable@...r.kernel.org> # v2.6.39+


Thanks

Takashi Sakamoto