linux-kernel - Re: [PATCH v6 46/57] usb: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Aug 2019 15:40:31 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Stephen Boyd <swboyd@...omium.org>, linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v6 46/57] usb: Remove dev_err() usage after platform_get_irq()


Hi,

Stephen Boyd <swboyd@...omium.org> writes:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
>
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
>
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
>
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
>
> While we're here, remove braces on if statements that only have one
> statement (manually).
>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-usb@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>
> Please apply directly to subsystem trees
>
>  drivers/usb/chipidea/core.c               |  1 -
>  drivers/usb/dwc2/platform.c               |  4 +---
>  drivers/usb/dwc3/dwc3-keystone.c          |  1 -
>  drivers/usb/dwc3/dwc3-omap.c              |  4 +---
>  drivers/usb/gadget/udc/aspeed-vhub/core.c |  1 -
>  drivers/usb/gadget/udc/bcm63xx_udc.c      |  8 ++------
>  drivers/usb/gadget/udc/bdc/bdc_core.c     |  4 +---
>  drivers/usb/gadget/udc/gr_udc.c           |  8 ++------
>  drivers/usb/gadget/udc/lpc32xx_udc.c      |  5 +----
>  drivers/usb/gadget/udc/renesas_usb3.c     |  4 +---
>  drivers/usb/gadget/udc/s3c-hsudc.c        |  4 +---
>  drivers/usb/gadget/udc/udc-xilinx.c       |  4 +---

For dwc2, dwc3, gadget and usb/phy:

Acked-by: Felipe Balbi <felipe.balbi@...ux.intel.com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)