[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Aug 2019 16:24:17 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
Cc: Javier Martinez Canillas <javierm@...hat.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Wolfram Sang <wsa@...-dreams.de>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Michal Marek <michal.lkml@...kovi.net>,
linux-kbuild <linux-kbuild@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Lee Jones <lee.jones@...aro.org>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH RFC] modpost: Support I2C Aliases from OF tables
On Thu, Aug 08, 2019 at 03:12:47PM +0200, Enrico Weigelt, metux IT consult wrote:
> On 06.08.19 19:12, Javier Martinez Canillas wrote:
>
> > Right, we could add a macro for that. Although it should probably be called
> > I2C_OF_MODULE_DEVICE_TABLE() or something like that since is specific to OF.
>
> At that point it should be completely noop when OF is disabled, so we
> also can get rid of many ifdef's.
Why?
> I've got some patch somewhere for introducing a MODULE_OF_TABLE() macro
> as replacement for many MODULE_DEVICE_TABLE(of, ...) cases, which noops
> when CONFIG_OF is disabled. (and similar ones for other table types).
It's simple wrong to have #ifdef CONFIG_OF without counterpart of_match_ptr().
And taking into consideration that ID table itself doesn't depend to OF at all,
why not simple drop that #ifdef and of_match_ptr() all together?
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists