linux-kernel - Re: [PATCH 1/1] fs/splice.c: Fix old documentation about moving pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 08 Aug 2019 15:19:41 -0300
From:   Leonardo Bras <leonardo@...ux.ibm.com>
To:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 1/1] fs/splice.c: Fix old documentation about moving
 pages

On Thu, 2019-08-01 at 19:38 -0300, Leonardo Bras wrote:
> Since commit 485ddb4b9741 ("1/2 splice: dont steal")' (2007),
> the SPLICE_F_MOVE support was removed (became a no-op according
> to man pages), and thus disabling steal operation that would make
> moving pages possible.
> 
> This fixes the comment, making clear pages are not moved.
> 
> Signed-off-by: Leonardo Bras <leonardo@...ux.ibm.com>
> ---
>  fs/splice.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/splice.c b/fs/splice.c
> index 14cb602d9a2f..0ba151c40cef 100644
> --- a/fs/splice.c
> +++ b/fs/splice.c
> @@ -671,8 +671,7 @@ ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out,
>   * @flags:	splice modifier flags
>   *
>   * Description:
> - *    Will either move or copy pages (determined by @flags options) from
> - *    the given pipe inode to the given file.
> + *    Will copy pages from the given pipe inode to the given file.
>   *    This one is ->write_iter-based.
>   *
>   */

Could you give any feedback on this patch?

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)