linux-kernel - Re: [PATCH] USB: storage: isd200: remove redundant assignment to variable sendToTransport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b68ee52d-f6d6-c626-3ed7-9b590fb1ed1b@canonical.com>
Date:   Fri, 9 Aug 2019 20:32:36 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: storage: isd200: remove redundant assignment to
 variable sendToTransport

On 09/08/2019 20:29, Alan Stern wrote:
> On Fri, 9 Aug 2019, Colin King wrote:
> 
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The variable sendToTransport is being initialized with a value that is
>> never read and is being re-assigned a little later on. The assignment
>> is redundant and hence can be removed.
>>
>> Addresses-Coverity: ("Unused value")
> 
> Of what use is that tag to general kernel developers?

This is being informally used so that we can track which bugs are
getting found with specific static analysis tools.  The public coverity
bug reports also have a CID# number.  I'm working on range of coverity
builds (different build configs) that are not public because I can crank
multiple builds per day to find issues.

Colin

> 
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  drivers/usb/storage/isd200.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/storage/isd200.c b/drivers/usb/storage/isd200.c
>> index 2b474d60b4db..28e1128d53a4 100644
>> --- a/drivers/usb/storage/isd200.c
>> +++ b/drivers/usb/storage/isd200.c
>> @@ -1511,7 +1511,7 @@ static int isd200_Initialization(struct us_data *us)
>>  
>>  static void isd200_ata_command(struct scsi_cmnd *srb, struct us_data *us)
>>  {
>> -	int sendToTransport = 1, orig_bufflen;
>> +	int sendToTransport, orig_bufflen;
>>  	union ata_cdb ataCdb;
>>  
>>  	/* Make sure driver was initialized */
> 
> Otherwise:
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>
> 
> Alan Stern
>