linux-kernel - Re: [PATCH v6 05/57] crypto: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Aug 2019 16:17:48 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH v6 05/57] crypto: Remove dev_err() usage after
 platform_get_irq()

On Tue, Jul 30, 2019 at 11:15:05AM -0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
> 
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
> 
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
> 
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
> 
> While we're here, remove braces on if statements that only have one
> statement (manually).
> 
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: <linux-crypto@...r.kernel.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
> 
> Please apply directly to subsystem trees
> 
>  drivers/crypto/atmel-aes.c             | 1 -
>  drivers/crypto/atmel-sha.c             | 1 -
>  drivers/crypto/atmel-tdes.c            | 1 -
>  drivers/crypto/ccree/cc_driver.c       | 4 +---
>  drivers/crypto/img-hash.c              | 1 -
>  drivers/crypto/mediatek/mtk-platform.c | 4 +---
>  drivers/crypto/mxs-dcp.c               | 8 ++------
>  drivers/crypto/omap-aes.c              | 1 -
>  drivers/crypto/omap-des.c              | 1 -
>  drivers/crypto/omap-sham.c             | 1 -
>  drivers/crypto/sahara.c                | 4 +---
>  drivers/crypto/stm32/stm32-cryp.c      | 4 +---
>  drivers/crypto/stm32/stm32-hash.c      | 4 +---
>  13 files changed, 7 insertions(+), 28 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt