linux-kernel - Re: [PATCH v3 1/2] selftests: kvm: Adding config fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+G9fYt4QPjHtyoZUfe_tv+uT6yybHehymuDWBFHL-QH3K-PxA@mail.gmail.com>
Date:   Fri, 9 Aug 2019 13:23:08 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Andrew Jones <drjones@...hat.com>,
        sean.j.christopherson@...el.com,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, kvm list <kvm@...r.kernel.org>,
        Dan Rue <dan.rue@...aro.org>
Subject: Re: [PATCH v3 1/2] selftests: kvm: Adding config fragments

On Fri, 9 Aug 2019 at 13:09, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> On 09/08/19 09:24, Naresh Kamboju wrote:
> > selftests kvm all test cases need pre-required kernel config for the
> > tests to get pass.
> >
> > CONFIG_KVM=y
> >
> > The KVM tests are skipped without these configs:
> >
> >         dev_fd = open(KVM_DEV_PATH, O_RDONLY);
> >         if (dev_fd < 0)
> >                 exit(KSFT_SKIP);
> >
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > Acked-by: Shuah Khan <skhan@...uxfoundation.org>
> > ---
> >  tools/testing/selftests/kvm/config | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 100644 tools/testing/selftests/kvm/config
> >
> > diff --git a/tools/testing/selftests/kvm/config b/tools/testing/selftests/kvm/config
> > new file mode 100644
> > index 000000000000..14f90d8d6801
> > --- /dev/null
> > +++ b/tools/testing/selftests/kvm/config
> > @@ -0,0 +1 @@
> > +CONFIG_KVM=y
> >
>
> I think this is more complicated without a real benefit, so I'll merge v2.

With the recent changes to 'kselftest-merge' nested configs also get merged.
Please refer this below commit for more details.
---
commit 6d3db46c8e331908775b0135dc7d2e5920bf6d90
Author: Dan Rue <dan.rue@...aro.org>
Date:   Mon May 20 10:16:14 2019 -0500

    kbuild: teach kselftest-merge to find nested config files

    Current implementation of kselftest-merge only finds config files that
    are one level deep using `$(srctree)/tools/testing/selftests/*/config`.

    Often, config files are added in nested directories, and do not get
    picked up by kselftest-merge.

    Use `find` to catch all config files under
    `$(srctree)/tools/testing/selftests` instead.

    Signed-off-by: Dan Rue <dan.rue@...aro.org>
    Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

- Naresh