linux-kernel - [PATCH] counter: fix devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Aug 2019 11:41:19 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     David Lechner <david@...hnology.com>
cc:     William Breathitt Gray <vilhelm.gray@...il.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...org
Subject: [PATCH] counter: fix devm_platform_ioremap_resource.cocci warnings

From: kbuild test robot <lkp@...el.com>

 Use devm_platform_ioremap_resource helper which wraps
 platform_get_resource() and devm_ioremap_resource() together.

Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci

Fixes: 78958c294246 ("counter: new TI eQEP driver")
Signed-off-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

tree:   https://github.com/dlech/linux bone-counter
head:   669cef0feba0b11f271f462c4d26e4d1449a9db8
commit: 78958c294246fe1177ff62518eef45d20ad0165e [5/8] counter: new TI eQEP driver
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago

Despite the fixes tag, this is not actually fixing a bug, it just makes
the code a little shorter.

 ti-eqep.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/counter/ti-eqep.c
+++ b/drivers/counter/ti-eqep.c
@@ -392,15 +392,13 @@ static int ti_eqep_probe(struct platform
 {
 	struct device *dev = &pdev->dev;
 	struct ti_eqep_cnt *priv;
-	struct resource *res;
 	void __iomem *base;

 	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
 		return -ENOMEM;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_ioremap_resource(dev, res);
+	base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(base))
 		return PTR_ERR(base);