linux-kernel - Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 09 Aug 2019 14:55:40 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     <broonie@...nel.org>
Cc:     YueHaibing <yuehaibing@...wei.com>, <lgirdwood@...il.com>,
        <pierre-louis.bossart@...ux.intel.com>, <yang.jie@...ux.intel.com>,
        <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: SOF: Intel: Add missing include file hdac_hda.h

On Fri, 09 Aug 2019 14:53:55 +0200,
Takashi Iwai wrote:
> 
> On Fri, 09 Aug 2019 13:01:00 +0200,
> YueHaibing wrote:
> > 
> > Building with SND_SOC_SOF_HDA_AUDIO_CODEC fails:
> > 
> > sound/soc/sof/intel/hda-bus.c: In function sof_hda_bus_init:
> > sound/soc/sof/intel/hda-bus.c:16:25: error: implicit declaration of function
> >  snd_soc_hdac_hda_get_ops; did you mean snd_soc_jack_add_gpiods? [-Werror=implicit-function-declaration]
> >  #define sof_hda_ext_ops snd_soc_hdac_hda_get_ops()
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Suggested-by: Takashi Iwai <tiwai@...e.de>
> > Fixes: d4ff1b3917a5 ('ASoC: SOF: Intel: Initialize hdaudio bus properly")
>                        ^
> Use " consistently for both opening and closing quotes.
> 
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Reviewed-by: Takashi Iwai <tiwai@...e.de>

Actually I'm going to take this again on top of
topic/hda-bus-ops-cleanup branch of my tree, so Mark, feel free to
pull onto yours again.

Sorry for the mess!


Takashi