linux-kernel - Re: [PATCH] staging: wusbcore: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190809125649.GA2531@kroah.com>
Date:   Fri, 9 Aug 2019 14:56:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     ard.biesheuvel@...aro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wusbcore: Fix build error without CONFIG_USB

On Fri, Aug 09, 2019 at 06:21:50PM +0800, YueHaibing wrote:
> USB_WUSB should depends on CONFIG_USB, otherwise building fails
> 
> drivers/staging/wusbcore/wusbhc.o: In function `wusbhc_giveback_urb':
> wusbhc.c:(.text+0xa28): undefined reference to `usb_hcd_giveback_urb'
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 71ed79b0e4be ("USB: Move wusbcore and UWB to staging as it is obsolete")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/staging/wusbcore/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig
> index 056c60b..a559d02 100644
> --- a/drivers/staging/wusbcore/Kconfig
> +++ b/drivers/staging/wusbcore/Kconfig
> @@ -4,7 +4,7 @@
>  #
>  config USB_WUSB
>  	tristate "Enable Wireless USB extensions"
> -	depends on UWB
> +	depends on UWB && USB
>  	select CRYPTO
>  	select CRYPTO_AES
>  	select CRYPTO_CCM
> -- 
> 2.7.4

Ah, good catch, sorry about that!

greg k-h