linux-kernel - Re: [PATCH -next] afs: remove unused variable 'afs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f410b332-8df5-927e-6e68-2b2c7a32f92c@auristor.com>
Date:   Fri, 9 Aug 2019 13:40:53 -0400
From:   Jeffrey E Altman <jaltman@...istor.com>
To:     YueHaibing <yuehaibing@...wei.com>, dhowells@...hat.com
Cc:     linux-kernel@...r.kernel.org, linux-afs@...ts.infradead.org
Subject: Re: [PATCH -next] afs: remove unused variable 'afs_voltypes'

This is true but I believe afs_voltypes should be used in the
afs_put_volume() and afs_deactivate_volume() enter() tracing.

If it will not be used for those calls then removal is correct.

Jeffrey Altman

On 8/9/2019 4:40 AM, YueHaibing wrote:
> fs/afs/volume.c:15:26: warning:
>  afs_voltypes defined but not used [-Wunused-const-variable=]
> 
> It is not used since commit d2ddc776a458 ("afs: Overhaul
> volume and server record caching and fileserver rotation")
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  fs/afs/volume.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/afs/volume.c b/fs/afs/volume.c
> index 1a41430..92ca5e2 100644
> --- a/fs/afs/volume.c
> +++ b/fs/afs/volume.c
> @@ -12,8 +12,6 @@
>  unsigned __read_mostly afs_volume_gc_delay = 10;
>  unsigned __read_mostly afs_volume_record_life = 60 * 60;
>  
> -static const char *const afs_voltypes[] = { "R/W", "R/O", "BAK" };
> -
>  /*
>   * Allocate a volume record and load it up from a vldb record.
>   */
> 

View attachment "jaltman.vcf" of type "text/x-vcard" (272 bytes)

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4033 bytes)