linux-kernel - Re: [PATCH -next] crypto: aes-generic - remove unused variable 'rco

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu88NxkdmKpDm3A4JTQYvOuUvUgz4NgPEAWCbqbuBkUqhg@mail.gmail.com>
Date:   Fri, 9 Aug 2019 20:49:59 +0300
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH -next] crypto: aes-generic - remove unused variable 'rco_tab'

On Fri, 9 Aug 2019 at 11:30, YueHaibing <yuehaibing@...wei.com> wrote:
>
> crypto/aes_generic.c:64:18: warning:
>  rco_tab defined but not used [-Wunused-const-variable=]
>
> It is never used, so can be removed.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
>  crypto/aes_generic.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/crypto/aes_generic.c b/crypto/aes_generic.c
> index 71a5c19..22e5867 100644
> --- a/crypto/aes_generic.c
> +++ b/crypto/aes_generic.c
> @@ -61,8 +61,6 @@ static inline u8 byte(const u32 x, const unsigned n)
>         return x >> (n << 3);
>  }
>
> -static const u32 rco_tab[10] = { 1, 2, 4, 8, 16, 32, 64, 128, 27, 54 };
> -
>  /* cacheline-aligned to facilitate prefetching into cache */
>  __visible const u32 crypto_ft_tab[4][256] ____cacheline_aligned = {
>         {
> --
> 2.7.4
>
>