linux-kernel - Re: [PATCH] scsi: sym53c8xx_2: remove redundant assignment to retv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190809181733.GQ5482@bombadil.infradead.org>
Date:   Fri, 9 Aug 2019 11:17:33 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Colin King <colin.king@...onical.com>
Cc:     "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: sym53c8xx_2: remove redundant assignment to retv

On Fri, Aug 09, 2019 at 06:59:32PM +0100, Colin King wrote:
> Variable retv is initialized to a value that is never read and it
> is re-assigned later. The initialization is redundant and can be
> removed.

Acked-by: Matthew Wilcox (Oracle) <willy@...radead.org>

Seems like a bit of a pointless class of warnings, given that gcc now
initialises all locals.  But I'm happy for James or Martin to pick it up.