linux-kernel - Re: [PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16c7c0c4a60.280e.85c95baa4474aabc7814e68940a78392@paul-moore.com>
Date:   Sat, 10 Aug 2019 11:01:16 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Amir Goldstein <amir73il@...il.com>
CC:     Aaron Goidel <acgoide@...ho.nsa.gov>, <selinux@...r.kernel.org>,
        LSM List <linux-security-module@...r.kernel.org>,
        "linux-fsdevel" <linux-fsdevel@...r.kernel.org>,
        David Howells <dhowells@...hat.com>, Jan Kara <jack@...e.cz>,
        James Morris <jmorris@...ei.org>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications

On August 10, 2019 6:05:27 AM Amir Goldstein <amir73il@...il.com> wrote:

>>>> Other than Casey's comments, and ACK, I'm not seeing much commentary
>>>> on this patch so FS and LSM folks consider this your last chance - if
>>>> I don't hear any objections by the end of this week I'll plan on
>>>> merging this into selinux/next next week.
>>>
>>> Please consider it is summer time so people may be on vacation like I was...
>>
>> This is one of the reasons why I was speaking to the mailing list and
>> not a particular individual :)
>
> Jan is fsnotify maintainer, so I think you should wait for an explicit ACK
> from Jan or just merge the hook definition and ask Jan to merge to
> fsnotify security hooks.

Aaron posted his first patch a month ago in the beginning of July and I don't recall seeing any comments from Jan on any of the patch revisions. I would feel much better with an ACK/Reviewed-by from Jan, or you - which is why I sent that email - but I'm not going to wait forever and I'd like to get this into -next soon so we can get some testing.

--
paul moore
www.paul-moore.com