linux-kernel - [PATCH 1/2] mfd: rave-sp: Bump command timeout to 5 seconds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190810154300.25950-1-festevam@gmail.com>
Date:   Sat, 10 Aug 2019 12:42:59 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org, andrew.smirnov@...il.com,
        cphealy@...il.com, l.stach@...gutronix.de, stable@...r.kernel.org,
        Fabio Estevam <festevam@...il.com>
Subject: [PATCH 1/2] mfd: rave-sp: Bump command timeout to 5 seconds

From: Andrey Smirnov <andrew.smirnov@...il.com>

Command to erase application firmware on RAVE SP takes longer than one
second (it takes ~3s). Bump command timeout duration to 5 seconds in
order to avoid bogus timeouts.

Cc: <stable@...r.kernel.org>
Fixes: 538ee27290fa ("mfd: Add driver for RAVE Supervisory Processor")
Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
Signed-off-by: Fabio Estevam <festevam@...il.com>
---
 drivers/mfd/rave-sp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rave-sp.c b/drivers/mfd/rave-sp.c
index 26c7b63e008a..546763d8a3e5 100644
--- a/drivers/mfd/rave-sp.c
+++ b/drivers/mfd/rave-sp.c
@@ -371,7 +371,7 @@ int rave_sp_exec(struct rave_sp *sp,
 
 	rave_sp_write(sp, data, data_size);
 
-	if (!wait_for_completion_timeout(&reply.received, HZ)) {
+	if (!wait_for_completion_timeout(&reply.received, 5 * HZ)) {
 		dev_err(&sp->serdev->dev, "Command timeout\n");
 		ret = -ETIMEDOUT;