linux-kernel - Re: [PATCH v2] f2fs: improve print log in f2fs_sanity_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD14+f3fiY8m7f91-ohHUj8ThMeYF7+Q=DU8c2c_8PTis8t-mw@mail.gmail.com>
Date:   Sun, 11 Aug 2019 04:53:37 +0900
From:   Ju Hyung Park <qkrwngud825@...il.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <yuchao0@...wei.com>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Chao Yu <chao@...nel.org>
Subject: Re: [PATCH v2] f2fs: improve print log in f2fs_sanity_check_ckpt()

Hi Jaegeuk,

I think we'll all appreciate if v1.13.0 gets tagged :)
I believe the current dev branch has been in good shape for quite some time now.

Thanks.


2019년 7월 11일 (목) 오전 10:31, Chao Yu <yuchao0@...wei.com>님이 작성:
>
> As Park Ju Hyung suggested:
>
> "I'd like to suggest to write down an actual version of f2fs-tools
> here as we've seen older versions of fsck doing even more damage
> and the users might not have the latest f2fs-tools installed."
>
> This patch give a more detailed info of how we fix such corruption
> to user to avoid damageable repair with low version fsck.
>
> Signed-off-by: Park Ju Hyung <qkrwngud825@...il.com>
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
> v2:
> - add fixing patch's title in log suggested by Jaegeuk.
>  fs/f2fs/super.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 1a6d82d558e4..47dae7c3ae4f 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2696,7 +2696,9 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
>
>         if (__is_set_ckpt_flags(ckpt, CP_LARGE_NAT_BITMAP_FLAG) &&
>                 le32_to_cpu(ckpt->checksum_offset) != CP_MIN_CHKSUM_OFFSET) {
> -               f2fs_warn(sbi, "layout of large_nat_bitmap is deprecated, run fsck to repair, chksum_offset: %u",
> +               f2fs_warn(sbi, "using deprecated layout of large_nat_bitmap, "
> +                         "please run fsck v1.13.0 or higher to repair, chksum_offset: %u, "
> +                         "fixed with patch: \"f2fs-tools: relocate chksum_offset for large_nat_bitmap feature\"",
>                           le32_to_cpu(ckpt->checksum_offset));
>                 return 1;
>         }
> --
> 2.18.0.rc1
>