[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <lsq.1565469607.25428937@decadent.org.uk>
Date: Sat, 10 Aug 2019 21:40:07 +0100
From: Ben Hutchings <ben@...adent.org.uk>
To: linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC: akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
"Zhiqiang Liu" <liuzhiqiang26@...wei.com>,
"Jie Liu" <liujie165@...wei.com>,
"David S. Miller" <davem@...emloft.net>,
"Miaohe Lin" <linmiaohe@...wei.com>,
"Qiang Ning" <ningqiang1@...wei.com>
Subject: [PATCH 3.16 095/157] tipc: set sysctl_tipc_rmem and named_timeout
right range
3.16.72-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Jie Liu <liujie165@...wei.com>
commit 4bcd4ec1017205644a2697bccbc3b5143f522f5f upstream.
We find that sysctl_tipc_rmem and named_timeout do not have the right minimum
setting. sysctl_tipc_rmem should be larger than zero, like sysctl_tcp_rmem.
And named_timeout as a timeout setting should be not less than zero.
Fixes: cc79dd1ba9c10 ("tipc: change socket buffer overflow control to respect sk_rcvbuf")
Fixes: a5325ae5b8bff ("tipc: add name distributor resiliency queue")
Signed-off-by: Jie Liu <liujie165@...wei.com>
Reported-by: Qiang Ning <ningqiang1@...wei.com>
Reviewed-by: Zhiqiang Liu <liuzhiqiang26@...wei.com>
Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
[bwh: Backported to 3.16: only the tipc_rmem sysctl exists here]
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
--- a/net/tipc/sysctl.c
+++ b/net/tipc/sysctl.c
@@ -37,6 +37,7 @@
#include <linux/sysctl.h>
+static int one = 1;
static struct ctl_table_header *tipc_ctl_hdr;
static struct ctl_table tipc_table[] = {
@@ -45,7 +46,8 @@ static struct ctl_table tipc_table[] = {
.data = &sysctl_tipc_rmem,
.maxlen = sizeof(sysctl_tipc_rmem),
.mode = 0644,
- .proc_handler = proc_dointvec,
+ .proc_handler = proc_dointvec_minmax,
+ .extra1 = &one,
},
{}
};
Powered by blists - more mailing lists